feat: use builtin.Empty instead of Unit typealias in Kotlin #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
wesbillman
approved these changes
Feb 8, 2024
Comment on lines
+99
to
105
| assert.Equal(t, map[string]any{}, resp.body) | ||
| }), | ||
| httpCall(rd, http.MethodDelete, "/users/123", jsonData(t, obj{}), func(t testing.TB, resp *httpResponse) { | ||
| assert.Equal(t, 200, resp.status) | ||
| assert.Equal(t, []string{"Header from FTL"}, resp.headers["Delete"]) | ||
| assert.Equal(t, nil, resp.body) | ||
| assert.Equal(t, map[string]any{}, resp.body) | ||
| }), |
There was a problem hiding this comment.
Maybe we should leave one of these Unit so we can ensure that nil works as well?
There was a problem hiding this comment.
the /empty path still tests Unit!
httpCall(rd, http.MethodGet, "/empty", nil, func(t testing.TB, resp *httpResponse) {
assert.Equal(t, 200, resp.status)
assert.Equal(t, nil, resp.headers["Content-Type"])
assert.Equal(t, nil, resp.bodyBytes)
}),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #878